public CI with github status

[jldec]

workflow

• push a commit
• see "in progress" github status
• wait reasonably short time for status ok (green) or fail (red)
• click through to CI log

questions / caveats

• work with PRs on forks (can't expose credential to code in fork)?
• cross-repo dependencies
• separate out image build (and push to dockerhub)

[jchesterpivotal]

As I see it:

• [x] Move repo to projectriff org (cred-alert comes back clean)
  • [x] Rename from pfs-ci to ci
  • [x] Change git resource definitions in pipelines
• [x] Audit tasks for logging of credentials
• [x] Backup database
• [x] Get the domain/URI and certificate sorted out
• [x] Change authorised team(s) to projectriff/riff-dev and projectriff/riff-watchers
• [x] Make fresh deployment without history
• [x] Open it up
• [x] Add cool badges to READMEs (in projectriff/ci#34)

[jchesterpivotal]

Added github status resource to pipeline, which tells Github about pending, failed and succeeded statuses per-commit.

[jchesterpivotal]

@jldec I think I've got the "workflow" bit done. I might suggest we split out PRs as another issue. Anything else you'd need before we close this one?

[jchesterpivotal]

Actually, scratch that, I have a bit more to do. It currently only applies status on the build-container jobs at the start of the pipeline. It'd be nice if it also updated it for other jobs, especially system tests.

[trisberg]

should we move the pivotal-cf/pfs-system-test to projectriff/acceptance-test?

change the sk8s docker hub user to riffci for images we use?

[jchesterpivotal]

No objection, but this issue has been fairly busy and I'm anxious to close it in its own right.

[jchesterpivotal]

Except, actually, you're right about both of those being private bits.

Ugh.

[jchesterpivotal]

Infinite todos

• [x] Add status to the acceptance test build can't be done with our current setup, it's not possible to determine which git resource is responsible for triggering the commit.
• [x] Separate statuses for CI repo changes can't be done with our current setup, it's not possible to determine which git resource is responsible for triggering the commit.
• [x] Status for helm charts
• [x] Add statuses to dockerimages This is being recalcitrant, so I am dropping it for now.
• [x] Move and rename pfs-system-test
• [ ] Swap over to riff dockerhub repo
  • [ ] Rename images, using ci- and demo- prefixes.
• [ ] Add statuses to riff-pr

[jchesterpivotal]

Actually, I have a hunch that I am wrong about not being able to set nice commit statuses for every job / commit permutation. The theory would be:

1. Set the status for every commit in every job.
2. Rely on the context key to distinguish what is going on (so a commit might be passed for ci/riff/build-http-gateway-container but pending on run-riff-system-tests-gke).
3. Use version: every to ensure we are testing all the permutations. Right now we don't.

[jchesterpivotal]

blocking on projectriff/ci#50

[jchesterpivotal]

I'm going to call this done. We have a public CI, images are pushed to public repos and so on. I'll break out missing FATS tests into another issue.