search

proksh / atomize

Design System for developers build on styled-components & React JS.
https://atomizecode.com/
Other
1.75k stars 344 forks source link

Collapse animation speed #32

Open ValiDraganescu opened 4 years ago

ValiDraganescu commented 4 years ago

Hi, I am using atomize for a toy project. I noticed that the collapse atom is not very snappy in it's animation, I'd like to speed up the animation. How to do this? Thank you!

ValiDraganescu commented 4 years ago

In Collapse.js I see 

render() {
    const { defaultHeight } = this.state;
    const { p, children, isOpen, ...rest } = this.props;

    /**
     * Duration for the transition
     */
    const duration = 400;
...

This means the duration is hardcoded?

proksh commented 4 years ago

Yes @ValiDraganescu, It is hardcoded right now. I will soon update it in the next version, for custom transitions.

ValiDraganescu commented 4 years ago

I ended up copying Collapse.js and modifying per my needs, it works for now

proksh commented 4 years ago

Great @ValiDraganescu

bobbylemm commented 3 years ago

@proksh I would like to know if this issue has been fixed

LucaMoro96 commented 3 years ago

@bobbylemm Not yet!

bobbylemm commented 3 years ago

@LucaMoro96 can I work on this

LucaMoro96 commented 3 years ago

@bobbylemm Sure!

bobbylemm commented 3 years ago

Alright great

manan1979 commented 1 year ago

hi @ValiDraganescu can i work on this?

ValiDraganescu commented 1 year ago

Hi @manan1979 , this is not my repo, I see others above offering to work on this one, so maybe check with @bobbylemm