search

proroklab / VectorizedMultiAgentSimulator

VMAS is a vectorized differentiable simulator designed for efficient Multi-Agent Reinforcement Learning benchmarking. It is comprised of a vectorized 2D physics engine written in PyTorch and a set of challenging multi-robot scenarios. Additional scenarios can be implemented through a simple and modular interface.
https://vmas.readthedocs.io
GNU General Public License v3.0
335 stars 69 forks source link

[Minor] - Defaults kwargs for dispersion env changed - Might result in different performance results #144

Closed KaleabTessera closed 1 month ago

KaleabTessera commented 1 month ago

When this commit was made the defaults for food_radius in dispersion was changed from 0.02 to 0.05. Might make minor performance differences for people using the default setting.

matteobettini commented 1 month ago

Hello! Yeah you are right, I think I was a bad person back then :(

Nowadays I would be way more careful about it.

Do you think there is something we can do to make it better? I don't know if reverting will improve the situation...

matteobettini commented 1 month ago

Sometimes some scenarios get major bc-breaking refactoring between versions, it will soon happen to football which is getting a LOT of new features and redesigns.

What i can do now is tag each commit that breaks old params with the bc-breaking tag and list the bc-breaking stuff in the version info. so that users that want to check if bc-breaking changes happened to their scenarios in newer vmas versions can look there.

KaleabTessera commented 1 month ago

Sounds like a good idea! @matteobettini You could also add a section in the release docs of which envs have breaking changes. Sometimes core dynamics get changed, and it hard to know if it will influence the env you are using.

matteobettini commented 1 month ago

Sounds like a good idea! @matteobettini You could also add a section in the release docs of which envs have breaking changes. Sometimes core dynamics get changed, and it hard to know if it will influence the env you are using.

I will! I'll keep an extra eye out for bc-breaking PRs and add them to the release notes.

We are currently having high-priority on not making bc-breaking changes so hopefully vmas will be a bit more stable in the future