search

prosyslab-classroom / cs348-information-security

61 stars 10 forks source link

[Question][Hw5] Should we consider unsigned comparison? #140

Closed nubi12336 closed 3 years ago

nubi12336 commented 3 years ago

In utils.ml, there are also unsigned comparison operators at Llvm.Icmp. Do we have to consider 'unsigned' when we write 'cmp' or 'filter' part? If so, should we cast signed integer to unsigned integer?

Standchen commented 3 years ago

In readme, it says:

  1. Implementing Value Domains and Memory Domain

In this homework, you will implement the sign domain and the taint domain in the corresponding module. Students are required to implement sound abstract semantic functions declared in the modules. Assume that all integers are signed and ignore integer-overflow effects.

So I guess we can just ignore unsigned operators... maybe?

KihongHeo commented 3 years ago

Yes. Ignore unsigned. Test cases will only consider signed integers.