protocol / research-website

PL Research website
https://research.protocol.ai/
2 stars 2 forks source link

Fix grants blog post #663

Closed jsoares closed 1 year ago

jsoares commented 1 year ago

I think we tried to comment out the groups and tags but commented out just the keys, which led to groups being interpreted as areas and tags being interpreted as categories. This broke not just the blog post

image

But the homepage too

image

This really should have been caught in PR review.

jsoares commented 1 year ago

Can we get the fix merged quickly? @brittyazel @jmoggr 🙏

brittyazel commented 1 year ago

Merged.

brittyazel commented 1 year ago

This was my fault. I had thought the list of groups was an intentional addition, and I was unaware that it would have ramifications outside of the specific post in question. When I was testing the prior merge, my attention was focused on the content. Apologies for my ignorance into how this particular CMS works, I'll make sure to test more thoroughly in the future.

jsoares commented 1 year ago

The problem here was just the # on lines 24 and 33. We could have commented out the entire list (what I did now) or nothing (if we really wanted the groups to show). By commenting out the key (e.g. for line 33, "groups"), it just kept processing subsequent uncommented list items as part of the previous known key ("areas").

Anyhow, this sort of thing is easy to miss in the code. It's much easier to catch by opening the preview link and just taking a quick look around. Usually it's enough to look at the home page and the actual added content, with a focus on metadata: common errors include typos in groups, authors, etc. that may cause Hugo to create new pages for the unknown taxonomy entry.

brittyazel commented 1 year ago

Yep, I see the issue now clear-as-day.

I had opened the preview link prior to merging, but, naively, I didn't navigate away from the blog post and onto the homepage. And, with this being my first post, I had thought listing the labs at the top was intentional, and I never questioned it. It also never entered my mind that simply adding a tag to a blog post would create, site-wide, a new area that would show on the homepage. The more you know.