prscX / react-native-toasty

React Native: Native Toast
Apache License 2.0
153 stars 39 forks source link

Fix tintColor android issue #38

Closed mzachariadis closed 3 years ago

mzachariadis commented 3 years ago

The missing default prop of titleColor leads to error on Android OS when the tintColor is used. This PR solves the #36 and #29 issues.

Until this PR is merged, a workaround could be the use of both titleColor and tintColor in the object props.

ahtisham09 commented 3 years ago

You need to send all the parameters as android class file try to get tint color and title color prop and if its null then there is no default values set to parse.

mzachariadis commented 3 years ago

Exactly! This is what this PR resolves. In the documentation there are default values available. Default value means that the prop definition is optional.

prscX commented 3 years ago

@mzachariadis for the Effort and PR.

I have merged the PR.

Thank </ Pranav >