search

pruiz / WkHtmlToXSharp

C# wrapper wrapper (using P/Invoke) for the excelent Html to PDF conversion library wkhtmltopdf library.
239 stars 84 forks source link

Explain please the following test case: CanHandleAuthFailure #23

Closed eugentorica closed 8 years ago

eugentorica commented 10 years ago

Now this test case is not run (ignored) with the following attribute: //[Ignore("This test requires (still to be released) wkhtmltopdf v0.12+")] I have a couple of questions: 1) What is expected result for this case? Why it is considered that tmp should be not null? 2) What functionality fo v0.12 is necessary for this case to work correctly.

Thank you all in advance.

pruiz commented 10 years ago

Hi,

The current version of wkhtmtopdf crashes on some auth failure scenarios. This is the reason this tests is not run as of now. On Mar 26, 2014 12:21 PM, "Eugeniu Torica" notifications@github.com wrote:

Now this test case is not run (ignored) with the following attribute: //[Ignore("This test requires (still to be released) wkhtmltopdf v0.12+")] I have a couple of questions: 1) What is expected result for this case? Why it is considered that tmp should be not null? 2) What functionality fo v0.12 is necessary for this case to work correctly.

Thank you all in advance.

Reply to this email directly or view it on GitHubhttps://github.com/pruiz/WkHtmlToXSharp/issues/23 .

eugentorica commented 10 years ago

Hi Pablo,

Do you mean crash in library or in wrapper. I've noticed that inside wrapper an exception is thrown

Class: DelegateQueue Method: public object EndInvoke(IAsyncResult result) Line: 492 Code: if(r.Error != null) { throw r.Error; }

This exception is not handled. Might be this cause of crash?

On Thu, Mar 27, 2014 at 12:39 AM, Pablo Ruiz García < notifications@github.com> wrote:

Hi,

The current version of wkhtmtopdf crashes on some auth failure scenarios. This is the reason this tests is not run as of now. On Mar 26, 2014 12:21 PM, "Eugeniu Torica" notifications@github.com wrote:

Now this test case is not run (ignored) with the following attribute: //[Ignore("This test requires (still to be released) wkhtmltopdf v0.12+")] I have a couple of questions: 1) What is expected result for this case? Why it is considered that tmp should be not null? 2) What functionality fo v0.12 is necessary for this case to work correctly.

Thank you all in advance.

Reply to this email directly or view it on GitHub< https://github.com/pruiz/WkHtmlToXSharp/issues/23> .

— Reply to this email directly or view it on GitHubhttps://github.com/pruiz/WkHtmlToXSharp/issues/23#issuecomment-38749542 .

pruiz commented 8 years ago

I've just tested this on win32 & win64 as part of a pre-release cycle and it works just fine. I am closing this, but please re-open if it keeps failing on your side.