search

pruiz / WkHtmlToXSharp

C# wrapper wrapper (using P/Invoke) for the excelent Html to PDF conversion library wkhtmltopdf library.
239 stars 84 forks source link

Removed hardcoded Common.Logging code references #33

Closed alexminza closed 8 years ago

alexminza commented 9 years ago

Should use the standard System.Diagnostics tracing infrastructure

alexminza commented 9 years ago

These changes allow for decoupling the project from strong references to Common.Logging classes and methods and allow for better packages upgrade and logging infrastructure management in dependent projects.

alexminza commented 9 years ago

Cc @pruiz

pruiz commented 8 years ago

Hi @alexminza,

First and foremost, let me thank you very much for your work.

While I am open to removing Common.Logging. Limiting logging suppor to Sys.Debugging.Trace, et. al. results in a somewhat reduced experience. And also, taking into account CoreCLR (and future .Net Fx versions) it looks like this is not going to be the 'default logging/tracing' on .Net anymore.. It looks like Microsoft.Framework.Logging is the (maybe) way to go.

So by now, and until a 'standarized' logging framework has ben found, removing Common.Logging should be done in favor of a minimal infrastructure within the project which handles logging using any sort of provider based logger/logger-factory (just a simplified version of what Common.Logging does). Where the consumer of WkHtmlToXSharp could simply plugin it's own adapter during initialization (which sinks everything into it's main logging infra).

Regards