fixing unexpected release of native callbacks

pruiz / WkHtmlToXSharp

C# wrapper wrapper (using P/Invoke) for the excelent Html to PDF conversion library wkhtmltopdf library.

239 stars 84 forks source link

fixing unexpected release of native callbacks #44

Closed martinhey closed 7 years ago

martinhey commented 7 years ago

When function callbacks are referenced on class level, gabarge collection of these pointers will take place when they are explicitely set to null or class is destroyed. So this prevetns from unexpected garbage collection (CallbackonCollectedDelegate)

pruiz commented 7 years ago

Have to check why tests are failing.. it may not have to do with this PR, as it looks like a network timeout. But have to check before merging, anyway.

martinhey commented 7 years ago

Was it a problem with my code that made tests fail?

pruiz commented 7 years ago

Nope, it looks like a timeout while rendering some online content within a test.

Sent from my iPhone

On 14 Mar 2017, at 07:32, Martin Hey notifications@github.com wrote:

Was it a problem with my code that made tests fail?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.