Launch GUI from non game partition

ps2homebrew / OPL-Launcher

22 stars 5 forks source link

Launch GUI from non game partition #10

Closed parrado closed 2 years ago

parrado commented 2 years ago

Pull Request checklist

Note: these are not necessarily requirements

[ ] I reformatted the code with clang-format
[X] I checked to make sure my submission worked
[X] I am the author of submission or have permission from the original author
[ ] Requires update of the PS2SDK
[ ] Requires update of the gsKit
[ ] Others (please specify below)

Pull Request description

This will allow OPL-Launcher to be loaded from a non-game partition.

Edit:

If OPL-Launcher is loaded from a partition whose name has the form PP.OPL*, OPL is called with no arguments to allow regular GUI loading.

parrado commented 2 years ago

Please don't merge yet. It seems magic HDL number is not safe to determine if partition is a game one.

parrado commented 2 years ago

@AKuHAK or @KrahJohlito could you please take a look. Thanks in advance.

AKuHAK commented 2 years ago

This pr looks really strange. I dont understand its purpose, TBH. It is using hardcoded path pp.opl, while we are now using conf_hdd, there are a lot unnecessary code formatting changes, and finally I dont quite understand what is the goal of this pr.

parrado commented 2 years ago

Actually hardcoded path PP.OPL doesn't refer to OPL partition but partition where OPL-Launcher is loaded from. Anyway I'm gonna think about a different approach.

The idea behind this PR is to allow OPL-Launcher be loaded from a partition with no game in it. For instance executable partitions, this will help users to launch a single OPL installation from either game partition (behaving as miniOPL) or OPL GUI from an executable partition from HDDOSD.

The origin of this PR took place after this question at psx-place https://www.psx-place.com/threads/how-to-boot-opl-gui-through-hddosd-with-opl-launcher.35547

AKuHAK commented 2 years ago

I just thought that opl already supports such behaviour by themself: when game fails to load it just get back to regular opl.

parrado commented 2 years ago

When OPL-Launcher is loaded from a partition with no game OPL hangs on white. That's why in this PR OPL is launched with no arguments if partition name has the form PP.OPL*

parrado commented 2 years ago

I'm gonna close this PR and make a fresh one in the next days.