search

psi4 / libxc

DEPRECATED since Psi4 v1.3 in favor of https://gitlab.com/libxc/libxc --- Miguel A.L. Marques's Exchange-correlation functionals for density-functional theory wrapped in CMake
http://www.tddft.org/programs/octopus/wiki/index.php/Libxc
Mozilla Public License 2.0
0 stars 1 forks source link

work_ files shouldn't be compiled #2

Closed susilehtola closed 5 years ago

susilehtola commented 7 years ago

I noticed that the new Psi4 build emits errors for the libxc build

/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_lda.c: In function ‘work_lda’:
/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_lda.c:75:5: warning: implicit declaration of function ‘func’ [-Wimplicit-function-declaration]
     func(p, &r);
     ^~~~
/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_gga_x.c: In function ‘work_gga_x’:
/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_gga_x.c:152:7: warning: implicit declaration of function ‘func’ [-Wimplicit-function-declaration]
       func(p, order, x, &f, &dfdx, &d2fdx2, &d3fdx3);
       ^~~~
/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_mgga_c.c: In function ‘work_mgga_c’:
/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_mgga_c.c:104:5: warning: implicit declaration of function ‘func’ [-Wimplicit-function-declaration]
     func(p, &r);
     ^~~~
/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_mgga_x.c: In function ‘work_mgga_x’:
/home/work/psi4/objdir/external/upstream/libxc/libxc_external-prefix/src/libxc_external-build/src/work_mgga_x.c:107:7: warning: implicit declaration of function ‘func’ [-Wimplicit-function-declaration]
       func(p, &r);
       ^~~~

These files shouldn't be compiled at all. They're #included in actual functional routines.

loriab commented 5 years ago

Fixed this at some point.