Uplift exporter code and repository

psyinfra / prometheus-eaton-ups-exporter

A Prometheus exporter for (some) Eaton UPSs

ISC License

13 stars 5 forks source link

Uplift exporter code and repository #27

Closed TobiasKadelka closed 6 months ago

TobiasKadelka commented 6 months ago

Makes code flake8 compliant
specifies imports (no import *)
improves error handling
adds pyproject.toml
adds github workflow file

Updated version of previous PR https://github.com/psyinfra/prometheus-eaton-ups-exporter/pull/26

TobiasKadelka commented 6 months ago

pyre, pytest, and the removal of the dependency will be addressed at a later point.

I added changes for the rest of your feedback, especially in regards of the requirements!

mathisloevenich commented 6 months ago

Nice to see you'all keeping this project updated 👍

aqw commented 6 months ago

Nice to see you'all keeping this project updated 👍

Absolutely!

Thanks for building an exporter with good bones. It's definitely worth maintaining! :-D

mathisloevenich commented 6 months ago

Nice to see you'all keeping this project updated 👍

Absolutely!

Thanks for building an exporter with good bones. It's definitely worth maintaining! :-D

Thanks, I appreciate that :)