Closed TobiasKadelka closed 3 months ago
Is that missing from this PR? Or was that done manually?
It was done manually.
The other feedback is implemented; Thanks a lot for your thoughts!
It was done manually.
This is OK for now, but for the sake of future sanity and ensuring that star credentials don't leak (it only takes one), this should be automated.
I will merge this PR as-is. Please put automated credential removal on your list somewhere. :-)
The main feature of this PR is to add pyre type checking and pytests to the CI workflow! It removes or simplifies imports and a lot of other code, as well as version specifications -- The aim is to simplify work and changes on the exporter in the future. :)
Changes:
urllib3
import withurllib3
from therequests.packages
(close #28)pytest-vcr
instead ofvcrpy
for testspyproject.toml
.gitignore