search

psyinfra / prometheus-eaton-ups-exporter

A Prometheus exporter for (some) Eaton UPSs
ISC License
13 stars 5 forks source link

combine --port and --host-address #4

Closed aqw closed 3 years ago

aqw commented 3 years ago

The ip:port syntax is common, and allows this to be exposed as a single option.

In the Prometheus community, the flag is usually called --web.listen-address.

For example:

--web.listen-address=":9290"
aqw commented 3 years ago

The --port and --host-address options should be removed, since --web.listen-address covers both use cases.

aqw commented 3 years ago

--web.listen-address should also be added to exporter.py (or argparsing removed from that file entirely).

The "Usage" section of the readme should also be updated.