search

pthom / imgui_bundle

Dear ImGui Bundle: an extensive set of Ready-to-use widgets and libraries, based on ImGui. Start your first app in 5 lines of code, or less. Whether you prefer Python or C++, this pack has your back!
https://pthom.github.io/imgui_bundle/
MIT License
666 stars 66 forks source link

ImSpinner Version Bump - Resolves Multiple Def Compilation Errors #209

Closed mrawlingst closed 4 months ago

mrawlingst commented 4 months ago

I noticed that ImSpinner was last "updated" (added as repo) back in 2022. If you tried to include ImSpinner in a header file that is used by multiple *.cpp (as is common), it will throw compilation errors that there are multiple definitions. There was an issue already opened on ImSpinner's repo: https://github.com/dalerank/imspinner/issues/10

This issue has been resolved in these two commits that happened in 2023:

Just asking for version bump of the ImSpinner in this bundle.

pthom commented 4 months ago

Hello

Done, see https://github.com/pthom/imgui_bundle/commit/0398bb43b3e98ec1f4b1fa2701b0bfb619a17bbf

mrawlingst commented 4 months ago

I can verify that the latest changes has fixed this issue. Thanks!