ptr727 / PlexCleaner

Utility to optimize media files for Direct Play in Plex, Emby, Jellyfin
MIT License
248 stars 12 forks source link

7zip download - incorrect url #324

Closed xstefen closed 4 months ago

xstefen commented 4 months ago

I believe the correct URL should be https://www.7-zip.org/a/7z2401-extra.7z whereas currently it attempts https://www.7-zip.org/a/7z2401 beta-extra.7z


Is this a new issue that can be reproduced using the latest version?

Which operating systems reproduce the issue?

Version information.

Win 11, latest PlexCleaner, latest Latest everything

Steps to reproduce?

PlexCleaner checkfornewtools --settingsfile PlexCleaner.json fails with same manually download 7z beta extract to Tools/SevenZip progresses further before failing with same

Commandline.

PlexCleaner checkfornewtools --settingsfile PlexCleaner.json

Relevant log output.

02:34:26 [INF] <1> SevenZip : Getting latest version ...
02:34:26 [INF] <1> SevenZip : Reading latest version from : "https://www.7-zip.org/download.html"
02:34:27 [INF] <1> SevenZip : Getting download URI details : "https://www.7-zip.org/a/7z2401 beta-extra.7z"
02:34:27 [ERR] <1> "GetContentInfo"
System.Net.Http.HttpRequestException: Response status code does not indicate success: 404 (Not Found).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at InsaneGenius.Utilities.Download.GetContentInfo(Uri uri, Int64& size, DateTime& modifiedTime)
02:34:27 [ERR] <1> SevenZip : Failed to get download URI details : "https://www.7-zip.org/a/7z2401 beta-extra.7z"
02:34:27 [INF] <1> Exit Code : 1

Settings file.

PlexCleaner.json

Log file.

https://bin.xstefen.dev/p/MiozYN.log

Media file information.

No response

ptr727 commented 4 months ago

My version regex failed for the beta text.
I changed to getting the latest version number and downloading from GitHub instead, more deterministic.
Can you try 3.5 pre-release and report if it works for you?

xstefen commented 4 months ago

Using 3.5.1-g817ea88ce9, 05:01:39 [INF] <1> Exit Code : 0. Well done. This docker process has been heating my room all day I'm excited to try nvenc w/o containers :)

Thx m8