pulibrary / approvals

Approval system for travel and absence requests at Princeton University Library
Other
0 stars 0 forks source link

Fix flaky feature tests #1165

Open sandbergja opened 1 month ago

sandbergja commented 1 month ago

What maintenance needs to be done?

Make the following tests more reliable and consistent:

rspec ./spec/features/report_spec.rb:17 # My Requests I can filter reports
rspec ./spec/features/my_requests_spec.rb:12 # My Requests I can filter my requests
rspec ./spec/features/my_requests_spec.rb:54 # My Requests I can sort my requests

Level of urgency

Why is this maintenance needed?

This test sometimes passes and sometimes fails in CI, so it's hard to tell whether or not this feature is working.

Acceptance criteria

Notes

This might be related to the select_drop_down custom test method.

This custom test method may not wait for the javascript to render, or might not see hidden elements on the page. It would be nice if we could use the capybara #select matcher for these tests.

kevinreiss commented 1 day ago

This issue is the select version of this issue in LUX https://github.com/pulibrary/lux-design-system/issues/225.

maxkadel commented 1 day ago

Blocked by https://github.com/pulibrary/lux-design-system/issues/348