The attrib subprocess is only available on Windows

pulsepm / pulse

Unofficial package manager written in python.

MIT License

4 stars 0 forks source link

The attrib subprocess is only available on Windows #39

Closed mysy00 closed 5 months ago

mysy00 commented 5 months ago

The attrib command is only available on Windows, it will fail on Linux and I believe this try&catch block should only except if there's an error with saving the configuration. On Linux you hide files and directories by prefixing them with a dot but it's not necessary here thanks to #38.

I'd argue it's also not necessary to hide anything on Windows neither but I'm not a Windows user, so I'm open to whatever anyone says.

Mergevos commented 5 months ago

Only reason I'm hiding it is because it's intended to be modified via pulse configure not manually..

mysy00 commented 5 months ago

We all know from sampctl's history how intentions and reality work. In theory most programs in the appdata directory don't plan to expose those files but I don't think many of them actually mark them as hidden. Somebody with Windows could check though.

Mergevos commented 5 months ago

Not merging. Instead we are removing hiding of the files. Thanks! #40