pulsepm / pulse

Unofficial package manager written in python.
MIT License
4 stars 0 forks source link

[BUG]: uninstall [package] [-r] #52

Closed defakuto closed 5 months ago

defakuto commented 5 months ago

Describe the bug It deletes the library properly but does not delete it from pulse.toml

To Reproduce Steps to reproduce the behavior:

  1. pulse uninstall -r

Expected behavior It should delete from pulse.toml

Desktop (please complete the following information):

Additional context Command Output
PS C:\Users\defak\OneDrive\Documents\GitHub\pulse_omp> pulse uninstall defakuto/samp-foreach-to-omp -r Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\pulsepm/omp-stdlib).
Found dependence pulsepm/omp-stdlib (master) in C:\Users\defak\AppData\Local\pulsepm\data\package\pulsepm/omp-stdlib/master!
Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\defakuto/samp-foreach-to-omp).
Package defakuto/samp-foreach-to-omp has been deleted.
defakuto commented 5 months ago

Also when you install again, duplicate [requirements] live = [ "pulsepm/omp-stdlib@master", "pulsepm/omp-stdlib@master",]

Ykpauneu commented 5 months ago

Could you give a more precise example because for now pulse uninstall works fine. Sequencing:

pulse.py install Ykpauneu/pmtest pulse.toml:

[requirements]
live = ["Ykpauneu/pmtest@main"]

pulse.py uninstall Ykpauneu/pmtest pulse.toml:

[requirements]
live = []

Describe the bug It deletes the library properly but does not delete it from pulse.toml

To Reproduce Steps to reproduce the behavior:

  1. pulse uninstall -r

Expected behavior It should delete from pulse.toml

Desktop (please complete the following information):

  • OS: Windows 11 Pro Version 10.0.22631 Build 22631

Additional context

Command Output PS C:\Users\defak\OneDrive\Documents\GitHub\pulse_omp> pulse uninstall defakuto/samp-foreach-to-omp -r Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\pulsepm/omp-stdlib). Found dependence pulsepm/omp-stdlib (master) in C:\Users\defak\AppData\Local\pulsepm\data\package\pulsepm/omp-stdlib/master! Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\defakuto/samp-foreach-to-omp). Package defakuto/samp-foreach-to-omp has been deleted.

Mergevos commented 5 months ago

Could you give a more precise example because for now pulse uninstall works fine. Sequencing:

pulse.py install Ykpauneu/pmtest pulse.toml:

[requirements]
live = ["Ykpauneu/pmtest@main"]

pulse.py uninstall Ykpauneu/pmtest pulse.toml:

[requirements]
live = []

Describe the bug It deletes the library properly but does not delete it from pulse.toml To Reproduce Steps to reproduce the behavior:

  1. pulse uninstall -r

Expected behavior It should delete from pulse.toml Desktop (please complete the following information):

  • OS: Windows 11 Pro Version 10.0.22631 Build 22631

Additional context Command Output PS C:\Users\defak\OneDrive\Documents\GitHub\pulse_omp> pulse uninstall defakuto/samp-foreach-to-omp -r Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\pulsepm/omp-stdlib). Found dependence pulsepm/omp-stdlib (master) in C:\Users\defak\AppData\Local\pulsepm\data\package\pulsepm/omp-stdlib/master! Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\defakuto/samp-foreach-to-omp). Package defakuto/samp-foreach-to-omp has been deleted.

I think it's with -r

Ykpauneu commented 5 months ago

Could you give a more precise example because for now pulse uninstall works fine. Sequencing: pulse.py install Ykpauneu/pmtest pulse.toml:

[requirements]
live = ["Ykpauneu/pmtest@main"]

pulse.py uninstall Ykpauneu/pmtest pulse.toml:

[requirements]
live = []

Describe the bug It deletes the library properly but does not delete it from pulse.toml To Reproduce Steps to reproduce the behavior:

  1. pulse uninstall -r

Expected behavior It should delete from pulse.toml Desktop (please complete the following information):

  • OS: Windows 11 Pro Version 10.0.22631 Build 22631

Additional context Command Output PS C:\Users\defak\OneDrive\Documents\GitHub\pulse_omp> pulse uninstall defakuto/samp-foreach-to-omp -r Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\pulsepm/omp-stdlib). Found dependence pulsepm/omp-stdlib (master) in C:\Users\defak\AppData\Local\pulsepm\data\package\pulsepm/omp-stdlib/master! Plugins not found (C:\Users\defak\AppData\Local\pulsepm\data\plugins\defakuto/samp-foreach-to-omp). Package defakuto/samp-foreach-to-omp has been deleted.

I think it's with -r

Also works with -r

defakuto commented 5 months ago

pulse uninstall [package](another package not stdlib) [-r]

It deletes the library properly but does not delete it from pulse.toml