Open forrest321 opened 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
I signed it!
CLAs look good, thanks!
Interested in this!
Requested changed are done.
This one fell off my radar, thought I'd get it done. Hope that helps.
Just a note, the sitemap generator might need a filter for anchor same page links (aka example.com/#home
). I'm kinda sure they shouldn't be included in a sitemap in basically any case but they get included in the current implementation.
My quick and dirty fix would be to just add page.url = page.url.replace(/#.*$/,'');
before the if (crawledPages.has(page.url)) {
so it removed the anchors but i'm not sure how that interferes with the original crawl function when people wanna build the graph
Added sitemap.xml gen