googlebot
commented
5 years ago Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
juanmardefago
While trying this script with both LazySizes and LazyLoad libraries, I found out that the tests would always fail. It seems that the bot user agent wasn't specified, either unintentionally or not, but it caused much confusion.
Lazyload uses the IntersectionObserver API, so the test failing cause lots of confusion about why was this happening.
Here's the issue where this was being discussed: https://github.com/verlok/lazyload/issues/277
This is the main repo for both libraries:
To clarify, I've run the script on a project i'm working on, which had two different implementations of lazyloading on different branches, one with lazysizes, another one with lazyload, and both failed, even though they are actually implemented in a way that should be compliant according to the docs (https://developers.google.com/search/docs/guides/lazy-loading).
Hope this helps.
Also, if the exclusion of the UA is intentional, It would be good to have an explanation. Someone actually asked this some time ago, but received no answer (https://github.com/GoogleChromeLabs/puppeteer-examples/issues/27).