search

puppetlabs / puppetlabs-splunk_hec

Apache License 2.0
9 stars 24 forks source link

(PIE-959) Agent Only Node Fact Broken #168

Closed RandomNoun7 closed 2 years ago

RandomNoun7 commented 2 years ago

The implementation of the fact splunk_hec_agent_only_node was flawed. It attempted to see if there was a difference between the server fact and the current nodes name. It turns out this is not a good method because in a multi master environment, a node might have a different name from the server fact, but it is still a server node that might run report processors.

This implementation looks at the services configured on the machine to determine if a puppetserver service has been registered.

Summary

Detailed Description

Checklist

[ ] Draft PR? [ ] Ensure README is updated [ ] Any changes to existing documentation [ ] Anything new added [ ] Link to external Puppet documentation [ ] Review Support Playbook for any needed updates [ ] Tags [ ] Unit Tests [ ] Acceptance Tests [ ] PR title is "(Ticket|Maint) Short Description" [ ] Commit title matches PR title

coreymbe commented 2 years ago

Closing this as #175 resolves the issue and has since been merged.