The splunk_hec_agent_only_node fact was flawed, in that it improperly resolved to true on infrastructure nodes (compilers, replica). This is caused by the fact previously checking if there was a difference between the server setting
and the current nodes certname.
Detailed Description
As compilers and replicas have Puppet Server running, but still report to the Primary the fact is incorrectly resolving to true, indicating the node is only running the Puppet agent.
The changes in this PR determines which OS the node is running, then will check the appropriate directory for the Puppet Server service file.
Checklist
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title
Summary
The
splunk_hec_agent_only_nodefact was flawed, in that it improperly resolved to true on infrastructure nodes (compilers, replica). This is caused by the fact previously checking if there was a difference between the server setting and the current nodes certname.Detailed Description
As compilers and replicas have Puppet Server running, but still report to the Primary the fact is incorrectly resolving to true, indicating the node is only running the Puppet agent.
The changes in this PR determines which OS the node is running, then will check the appropriate directory for the Puppet Server service file.
Checklist
[X] PR title is "(Ticket|Maint) Short Description" [X] Commit title matches PR title