search

purpleteam-labs / purpleteam

CLI component of OWASP PurpleTeam
https://owasp.org/www-project-purpleteam
Other
118 stars 15 forks source link

app-scanner: Replace axios and http-proxy-agent with existing got and hpagent #112

Closed binarymist closed 2 years ago

binarymist commented 2 years ago

In the app-scanner:

Remove dependencies: axios and http-proxy-agent. Both are used in app.emissary.js only. Use existing dependencies got and hpagent in app.emissary.js instead. There is an example of how got and hpagent is being used in zAp.js. Do something similar, may not need to extend though.

ShubhamPalriwala commented 2 years ago

Hey, I looked into the code and I cannot see any use/dependency of either axios or http-proxy-agent? Do we use some other branch for development other than master?

binarymist commented 2 years ago

Hi @ShubhamPalriwala .

Hey, I looked into the code and I cannot see any use/dependency of either axios or http-proxy-agent?

https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/main/src/api/app/models/app.emissary.js#L17-L18

Do we use some other branch for development other than master?

There is no master

ShubhamPalriwala commented 2 years ago

Oh okay I didn't know we are having all our issues logged here! I'll start this working!!