refactor: Enhance code quality and cli module

pwnwriter / haylxon

⚡ Blazing-fast tool to grab screenshots of your domain list right from terminal.

https://crates.io/crates/hxn

MIT License

386 stars 16 forks source link

refactor: Enhance code quality and cli module #19

Closed MrFixThis closed 11 months ago

MrFixThis commented 11 months ago

Improved screenshot capturing logic, enhanced helper functions and improved CLI argument parsing specification

MrFixThis commented 11 months ago

Days ago I came across this project and I really like its concept, so here are some general improvements I made to the application.

Some of them are:

Improved cli argument parsing specification.
Some unit tests added to the args submodule.
Improved code readability and quality of the screenshot module.
Removed unnecessary heap alloctions for errors using anyhow crate.

All these details translate into better quality and speed.

MrFixThis commented 11 months ago

I almost forgot. I've updated the README.md to add the new --file-path | -f positional argument in the section where the functionality to read the contents of a file is shown.

Please update the example screenshot.

pwnwriter commented 11 months ago

Hey @MrFixThis,

Thanks a ton for your help! You've really stepped up the game of HXN. awesome! Let's get that pr merged :heart_eyes_cat:

Cheers!