search

pylessard / python-udsoncan

Python implementation of UDS (ISO-14229) standard.
MIT License
588 stars 203 forks source link

flexray #109

Closed danielhrisca closed 1 year ago

danielhrisca commented 2 years ago

Hello @pylessard

I'm working on integrating Flexray support for UDS. This would need some minor changes to this packages and bigger changes on python-can-isotp:

Do you think this changes could work? Or do you think a separate package for Flexray isotp would be better?

pylessard commented 2 years ago

Hi @danielhrisca, I'm am not so familiar with flexray, but shouldn't it replace the Link Layer, meaning replace the pythoncan module? Is there a standard that explain how UDS over flexray should be done? Does it use ISOTP as well?

In any case, if the modification are major and interfaces are to be broken, I would maybe prioritize creating a new module for flexray. For this module, I expect a new Connection object only, so that is fine by me

danielhrisca commented 2 years ago

Yes it is mostly the transport layer that needs adjusting.

In this package it is needed to remove this hard assert if other transports are to be supported https://github.com/pylessard/python-udsoncan/blob/master/udsoncan/connections.py#L448 with the PythonIsoToConnection class

pylessard commented 2 years ago

Alright, if you can make something that doesn't break the interface, i'm all good. My requirements are to be backward compatible and keeping the unit test passing (unless a test needs an update for reasonable reason).

Thanks!

pylessard commented 1 year ago

Should I close that?