search

pylessard / python-udsoncan

Python implementation of UDS (ISO-14229) standard.
MIT License
575 stars 199 forks source link

Add custom services by extending BaseService #149

Closed HugGa closed 1 year ago

HugGa commented 1 year ago

This PR performs two total actions: Fixes a bug in udsoncan services relating to passing a configuration that has data_identifiers as part of its dictionary not functioning. And allows for response_ids and request_ids to be taken from the subclasses of BaseService, this allows for services to be created outside of udsoncan that don't quite fit the UDS specification but still behave similarly to other portions of the UDS protocol and prevents a need to dive into IsoTP sockets when otherwise unnecessary.

pylessard commented 1 year ago

Nice! It passes all unit test. I am happy :)

Thank you