search

pylessard / python-udsoncan

Python implementation of UDS (ISO-14229) standard.
MIT License
575 stars 199 forks source link

Can BaseService become part of the public API? #154

Closed lumagi closed 1 year ago

lumagi commented 1 year ago

Hi,

I noticed that you moved the BaseService in #150. After seeing #149 get merged, I wanted to ask if the BaseService is now part of the public API and this is its final resting place or if you could be moved to make it part of the public API due to #149?

Regards, Lukas

pylessard commented 1 year ago

I moved BaseService because I had a circular dependecy problem. That was the only solution that wouldn't break the interface.

You can import like this : from udsoncan import BaseService. Should work and be future proof

Cheers

lumagi commented 1 year ago

Great, thanks for the quick response.