Request timeout is integer but constructor expects boolean

pylessard / python-udsoncan

Python implementation of UDS (ISO-14229) standard.

MIT License

575 stars 199 forks source link

Request timeout is integer but constructor expects boolean #161

Closed prasadghole closed 1 year ago

prasadghole commented 1 year ago

def __init__(self, conn: BaseConnection, config: ClientConfig = default_client_config, request_timeout: Optional[bool] = None): Client.py expects boolean but timeout should be integer.

My pyright typechecker is giving me error when I use positive integer number as timeout value.

pylessard commented 1 year ago

Fixed in v1.18.1. Please confirm that this issue is resolved.

prasadghole commented 1 year ago

Yes it is fixed in version 1.18.1