search

pylessard / python-udsoncan

Python implementation of UDS (ISO-14229) standard.
MIT License
575 stars 199 forks source link

Compatible ID29 #181

Closed kirya-dev closed 10 months ago

pylessard commented 10 months ago

@joeFischetti : As the original author of the j2534 extension, I would love to have your feedback. I do not know J2534 myself, never used it.

pylessard commented 10 months ago

@kirya-dev : I see no issue with your code, but my knowledge of J2534 is limited. How thorough were your test? Do you think it is feasible to add unit test for that module?

kirya-dev commented 10 months ago

I think it possible, but I not have such experience in python tests 🤔 You can push scaffolding for it. I fix it for that task.

I think we need write any layer between DLL & J2534 class