Improvement with processing J2534 Connection

pylessard / python-udsoncan

Python implementation of UDS (ISO-14229) standard.

MIT License

588 stars 203 forks source link

Closed kirya-dev closed 5 days ago

kirya-dev commented 1 month ago

Points of improvement:

Made Close device after Discconnect. Previously, cant reconnect to the device (ERR_DEVICE_IN_USE).
Avoid debug log after error log.
Raising abnormal exception around connection to the J2534 device.
Fix error J2534 Error: CAN_ID_BOTH and CAN_29BIT_ID are the only valid ConnectFlags according J2534 standard.
Fix error Parameter pInput must be NULL.
Add read_vbatt for j2534 connection
Avoid extra access to DLL (log_last_operation)
Fix PassThruStartMsgFilter for any interfaces according standard (Sets 0xCCCC_CCCC as a stub. Devices like OpenPoprt and Pulsar are not receiving messages correctly)

pylessard commented 1 month ago

Thank you for this. I added 2 comments. Will merge as soon as I get your feedback and CI is green (will enable it for this PR soon)

pylessard commented 1 month ago

Right now my PC is out of order. Will check to make CI happy next week

kirya-dev commented 1 week ago

I dont know why. Devices like OpenPort and Pulsar are not receiving messages correctly when no set RxStatus & ExtraDataindex stub value 0xCCCC_CCCC.

pylessard commented 1 week ago

I can't help. I never used J2534 :(

kirya-dev commented 1 week ago

I think it is some legacy.

pylessard commented 1 week ago

Do you plan other modifications?

kirya-dev commented 6 days ago

Do you plan other modifications?

I work with this software every day on different devices and find different bugs 🐞. At the moment, the udsoncan library is working quite stable.

pylessard commented 5 days ago

Can you apply this patch to your PR? That will make static analysis happy. The CI machine up and running

kirya-dev commented 5 days ago

Hmm. Container ubuntu:20.04 not same win32 😁

kirya-dev commented 5 days ago

Definition of WindowsError in builtins.pyi

if sys.platform == "win32":
    WindowsError = OSError

I just replaced the exception type.

pylessard commented 5 days ago

Yeah. Will do a cleaner fix later. I think I can force mypy to assume windows through a mypy.ini