search

pylessard / python-udsoncan

Python implementation of UDS (ISO-14229) standard.
MIT License
578 stars 199 forks source link

RequestFileTransfer.interpret_response() incorrectly parses Filesize #89

Closed trivialpursuer closed 3 years ago

trivialpursuer commented 3 years ago

When parsing a response to a FileTransfer request with moop ReadFile, the Filesize object is incorrectly parsed if the lengthFormatIdentifier != fileSizeOrDirInfoParameterLength. I believe it's a simple copy/paste error in the parsing logic where lfid was not updated to fsodipl, so the code is assuming that the number of bytes in each filesize field is equal to the value in lfid.

trivialpursuer commented 3 years ago

Merged, thanks!

pylessard commented 3 years ago

Included in v1.14