False negatives in check_model_guide_match()

pyro-ppl / pyro

Deep universal probabilistic programming with Python and PyTorch

http://pyro.ai

Apache License 2.0

8.55k stars 987 forks source link

False negatives in check_model_guide_match() #2288

Open fritzo opened 4 years ago

fritzo commented 4 years ago

@mbabadi writes:

After a certain version of Pyro (I didn't keep track), model sampling sites without matching guide sampling sites are acceptable (no exception is thrown). I believe the current behavior is that Pyro effectively sets the posterior to the prior. We were used to the fail-fast behavior, and this led to wrong inferences in an application where we forgot a guide sampling statement by mistake.

fritzo commented 4 years ago

@mbabadi could you provide an example? I haven't been able to reproduce this and I don't see where the error might be happening in check_model_guide_match(). Feel free to close this issue if the problem has been solved.