Closed abeppu closed 2 years ago
hello @abeppu thanks for the detailed report. you can avoid this error by using a smaller learning rate:
python bart.py -lr 0.01
i put up a PR #3002 to use a more conservative default learning rate.
generally speaking, these kinds of numerical issues are par for the course for complex optimization problems. we do not run optimization to completion in continuous integration, since doing so would be prohibitively expensive. in practice training any complex model will require the user to explore optimization hyperparameters to find the right setting for the problem at hand
I'm just attempting to get started using pyro, and was trying to work through examples when I found that the example listed on the example page under "Multivariate Forecasting" reliably fails for me.
I see that there is a related open issue which is quite old https://github.com/pyro-ppl/pyro/issues/2017 which has some suggestions for the broader problem which seemed promising, but the PR following the approach discussed (https://github.com/pyro-ppl/pyro/pull/2019) was never approved.
It's not impossible that this is due to some environmental factor. However, I created a clean virtualenv to explore pyro. If there's some environmental contributing factor which I am not aware of, please document it, or even better, add a helper method to health-check a given environment.
If you can confirm/reproduce the failure, I would respectfully suggest that either
Issue Description
examples/contrib/forecast/bart.py
fails with cholesky error when run with default params (no args)Note that this example attempts to use the
backtest
method, which trains a model several times over different time windows. The first several such windows succeed.The error appears as follows:
Environment
Note, I get the same behavior on linux in docker.
Code Snippet
copy-pasted the example here: https://pyro.ai/examples/forecast_simple.html / https://github.com/pyro-ppl/pyro/blob/dev/examples/contrib/forecast/bart.py and simply ran: