Maintenance fixes - Githubissues

pyro-ppl / pyro

Deep universal probabilistic programming with Python and PyTorch

http://pyro.ai

Apache License 2.0

8.59k stars 987 forks source link

Maintenance fixes #3398

Closed ordabayevy closed 2 months ago

ordabayevy commented 2 months ago

Deprecated API usages found by TorchFix linter (https://github.com/pyro-ppl/pyro/pull/3397#issuecomment-2357456164)
Remove tests for deprecated torch.triangular_solve
Replace deep_getattr function with Python's operator.attrgetter

kit1980 commented 2 months ago

You can add TorchFix to the CI to prevent regressions and get future improvements. It would be very easy if you run flake8, but I see you recently removed flake8 from the CI...

ordabayevy commented 2 months ago

Yes, we moved from flake8 to ruff because it is much faster. Do you plan to support ruff in the future?

kit1980 commented 2 months ago

For ruff everything needs to be rewritten completely, in Rust. Maybe someone from ruff community will do that. TorchFix already uses LibCST as the main library, which is written in Rust, so should be fast already. Maybe you want to re-enable flake8 just for TorchFix?

Also there is a standalone torchfix script besides the flake8 interface, but currently it doesn't have support for running in CI.

martinjankowiak commented 2 months ago

thanks @kit1980 !

we probably don't want to bring flake8 back into our CI, but i've made an issue to track this in case future versions of torchfix can be brought into our CI more easily: #3399