pyronear / pyronear.github.io

Website of Pyronear
https://pyronear.org
Apache License 2.0
5 stars 10 forks source link

Add language ca and es #27

Closed psd24 closed 1 year ago

psd24 commented 1 year ago

Hey there :) Thanks for the PR and translating! First off, I don't speak catalan so I can't check that part of the PR. Also, high-level question: I fully understand how it's relevant to add spanish, and perhaps even portuguese. However, the languages we first add need to be well picked: considering the situation in south america, adding portuguese on top of spanish makes total sense. And I imagine a visitor understands clearly how the languages are linked to the most impacted regions of the globe. I'm not against it, but I'd be curious to hear why you added catalan in that regards?

Apart from that, I added some comments, let me know what you think!

Add the Catalan language because we are the organization that has donated the cameras in order to improve the algorithm. We like being able to contribute to this project and promote it in our territory and thus be able to do things together.

I am with you that we would have to add the Portuguese language. Also give support in South America.

If you think that the Catalan language is not necessary, I would understand it and it can be removed.

MateoLostanlen commented 1 year ago

@frgfm All the changes have been made and the logo is not available online, is that ok with you?

fe51 commented 1 year ago

@frgfm :)