Closed jreades closed 7 years ago
Great - let's hangout next week to continue evolving this.
I could do between 2-4pm Monday or anytime between 1-6:30pm Wednesday? That's my time, alas. :-)
Thursday and Friday I would appear to have nothing in the calendar at all!
Jon
Sent from my phone
On 25 Nov 2016, at 16:38, Sergio Rey notifications@github.com wrote:
Great - let's hangout next week to continue evolving this.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Let's shoot for 6pm (your time) Wednesday. I'll send a google invite shortly.
Some of this is uncontroversial (fixing a typo, adding some utility functions to the parser notebook file). I've left the more controversial (if you will) stuff in parser-mod.ipynb so that you can see the quite different approach that I was taking before you pointed out that I'd missed your pull request. Maybe a Google hangout next week to discuss? Your approach looks more OO/Pythonic, but mine may have a few useful features worth adapting.