python-graphblas / graphblas-algorithms

Graph algorithms written in GraphBLAS
Apache License 2.0
76 stars 4 forks source link

Update to use `to_coo/from_coo` instead of `to_values/from_values` #32

Closed eriknw closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Base: 72.84% // Head: 72.68% // Decreases project coverage by -0.15% :warning:

Coverage data is based on head (486ea22) compared to base (77c580c). Patch coverage: 86.95% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #32 +/- ## ========================================== - Coverage 72.84% 72.68% -0.16% ========================================== Files 69 69 Lines 2585 2581 -4 Branches 470 470 ========================================== - Hits 1883 1876 -7 - Misses 536 538 +2 - Partials 166 167 +1 ``` | [Impacted Files](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas) | Coverage Δ | | |---|---|---| | [graphblas\_algorithms/classes/nodeset.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvY2xhc3Nlcy9ub2Rlc2V0LnB5) | `66.19% <ø> (-1.41%)` | :arrow_down: | | [graphblas\_algorithms/nxapi/cluster.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvbnhhcGkvY2x1c3Rlci5weQ==) | `78.21% <0.00%> (ø)` | | | [graphblas\_algorithms/classes/\_utils.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvY2xhc3Nlcy9fdXRpbHMucHk=) | `67.34% <66.66%> (ø)` | | | [graphblas\_algorithms/algorithms/cluster.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvYWxnb3JpdGhtcy9jbHVzdGVyLnB5) | `92.51% <100.00%> (ø)` | | | [graphblas\_algorithms/algorithms/core.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvYWxnb3JpdGhtcy9jb3JlLnB5) | `100.00% <100.00%> (ø)` | | | [graphblas\_algorithms/algorithms/dag.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvYWxnb3JpdGhtcy9kYWcucHk=) | `93.54% <100.00%> (ø)` | | | [...as\_algorithms/algorithms/shortest\_paths/generic.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvYWxnb3JpdGhtcy9zaG9ydGVzdF9wYXRocy9nZW5lcmljLnB5) | `85.18% <100.00%> (ø)` | | | [graphblas\_algorithms/algorithms/simple\_paths.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvYWxnb3JpdGhtcy9zaW1wbGVfcGF0aHMucHk=) | `88.23% <100.00%> (ø)` | | | [graphblas\_algorithms/algorithms/tournament.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvYWxnb3JpdGhtcy90b3VybmFtZW50LnB5) | `100.00% <100.00%> (ø)` | | | [graphblas\_algorithms/classes/nodemap.py](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas#diff-Z3JhcGhibGFzX2FsZ29yaXRobXMvY2xhc3Nlcy9ub2RlbWFwLnB5) | `50.25% <100.00%> (ø)` | | | ... and [5 more](https://codecov.io/gh/python-graphblas/graphblas-algorithms/pull/32/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

eriknw commented 2 years ago

The failing test is a likely bug on networkx main branch: https://github.com/networkx/networkx/issues/6220

Merging anyway.

eriknw commented 2 years ago

Wait, this didn't merge?! Ugh. I already released.