Closed eriknw closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
09776b6
) 71.62% compared to head (e840706
) 71.62%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
nope looks the same
On Sat, 22 Apr 2023 at 03:39, Erik Welch @.***> wrote:
@.**** commented on this pull request.
On docs/_static/img/logo-name-medium.svg https://github.com/python-graphblas/graphblas-algorithms/pull/60#discussion_r1174179629 :
Okay, I think the logo should be fixed now if you'd like to take a look to verify.
— Reply to this email directly, view it on GitHub https://github.com/python-graphblas/graphblas-algorithms/pull/60#discussion_r1174179629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2FWESMMOA7WNUKCUXOEUTXCL5A3ANCNFSM6AAAAAAW7UPWYM . You are receiving this because your review was requested.Message ID: @.*** com>
nope looks the same
Dope! Thanks for checking. Jim and I have learned that the font looks very different on different systems (Windows, Mac, Android, etc). So, I think @jim22k is going to convert all the svg logos to PNGs (Jim, don't forget to minimize the PNGs--such as from https://compresspng.com/ and https://tinypng.com/ --to improve page load times!).
I switched from svg to png. This bumps the logo size from 1k to 35k, but I think it's worth it to avoid the need to grab fonts from the local machine, which leads to different looks and widths. PNG will always be consistent.
Thanks for converting the svg font to paths @jim22k. I minified the svg (that you converted the font into paths) with https://vecta.io/nano and deleted the png, b/c the svg looks better.
I think this is good to go in :tada:
Now let's do the same for the svgs in python-graphblas
:)
This is a companion PR to https://github.com/python-graphblas/python-graphblas/pull/432
I copied the logo from that PR and manually modified it.