python-graphblas / graphblas-algorithms

Graph algorithms written in GraphBLAS
Apache License 2.0
73 stars 4 forks source link

Add logo and benchmarks to README #60

Closed eriknw closed 1 year ago

eriknw commented 1 year ago

This is a companion PR to https://github.com/python-graphblas/python-graphblas/pull/432

I copied the logo from that PR and manually modified it.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (09776b6) 71.62% compared to head (e840706) 71.62%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ======================================= Coverage 71.62% 71.62% ======================================= Files 89 89 Lines 3461 3461 Branches 642 642 ======================================= Hits 2479 2479 Misses 783 783 Partials 199 199 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=python-graphblas)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

SultanOrazbayev commented 1 year ago

nope looks the same

On Sat, 22 Apr 2023 at 03:39, Erik Welch @.***> wrote:

@.**** commented on this pull request.

On docs/_static/img/logo-name-medium.svg https://github.com/python-graphblas/graphblas-algorithms/pull/60#discussion_r1174179629 :

Okay, I think the logo should be fixed now if you'd like to take a look to verify.

— Reply to this email directly, view it on GitHub https://github.com/python-graphblas/graphblas-algorithms/pull/60#discussion_r1174179629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2FWESMMOA7WNUKCUXOEUTXCL5A3ANCNFSM6AAAAAAW7UPWYM . You are receiving this because your review was requested.Message ID: @.*** com>

eriknw commented 1 year ago

nope looks the same

Dope! Thanks for checking. Jim and I have learned that the font looks very different on different systems (Windows, Mac, Android, etc). So, I think @jim22k is going to convert all the svg logos to PNGs (Jim, don't forget to minimize the PNGs--such as from https://compresspng.com/ and https://tinypng.com/ --to improve page load times!).

jim22k commented 1 year ago

I switched from svg to png. This bumps the logo size from 1k to 35k, but I think it's worth it to avoid the need to grab fonts from the local machine, which leads to different looks and widths. PNG will always be consistent.

eriknw commented 1 year ago

Thanks for converting the svg font to paths @jim22k. I minified the svg (that you converted the font into paths) with https://vecta.io/nano and deleted the png, b/c the svg looks better.

I think this is good to go in :tada:

Now let's do the same for the svgs in python-graphblas :)