python-trio / trio-typing

Type hints for Trio and related projects
Other
27 stars 14 forks source link

Support running without the mypy plugin #2

Closed oremanj closed 5 years ago

oremanj commented 5 years ago

Calls to @takes_callable_and_args functions won't have the args type-checked without the plugin, but that's better than unconditionally failing. In order to be more non-plugin-friendly, replace the trio_typing.ArgsForCallable marker type with mypy_extensions.VarArg(). Add tests for reasonable behavior when the plugin is absent.

oremanj commented 5 years ago

Travis is terminally confused about whether it should build the branch or not. I'm going to close this and submit another PR from a clone in my personal namespace.

njsmith commented 5 years ago

Oo yeah some of these services get confused when a repo is moved. I can never remember which one does which weird behavior. But it's possible you might even have to deregister from Travis and then re-register.