pytorch / torchchat

Run PyTorch LLMs locally on servers, desktop and mobile
BSD 3-Clause "New" or "Revised" License
3.32k stars 213 forks source link

Add support for separate bias tensors #1250

Closed gabe-l-hart closed 2 weeks ago

gabe-l-hart commented 3 weeks ago

🚀 The feature, motivation and pitch

In the transformers implementation of llama, there are optional bias tensors for the LlamaMLP and LlamaAttention modules. Several additional models (specifically Granite Code 3B and 8B) use the llama architecture and have these separate bias tensors.

The proposal here is to add the ability to indicate the presence of bias tensors in TransformerArgs and then support loading them in Attention and FeedForward

Alternatives

If this project is designed to be limited to official Llama models, these bias tensors are not needed.

Additional context

This issue is a piece of the puzzle for adding support for Granite Code 3b/8b which use the llama architecture in transormers, but take advantage several pieces of the architecture that are not currently supported by torchchat. The work-in-progress for Granite Code can be found on my fork: https://github.com/gabe-l-hart/torchchat/tree/GraniteCodeSupport

RFC (Optional)

I have a working implementation to support these optional bias tensors that I plan to submit as a PR. The changes are along the following lines:

Jack-Khuu commented 3 weeks ago

Love it, if you want to spin up a PR, I'll gladly take a look

gabe-l-hart commented 3 weeks ago

Draft PR up: https://github.com/pytorch/torchchat/pull/1259

Currently, I have all of my branches in sequence in order to avoid merge conflicts since many of them touch similar portions of the code (particularly around TransformerArgs).