pytorch / torchchat

Run PyTorch LLMs locally on servers, desktop and mobile
BSD 3-Clause "New" or "Revised" License
3.33k stars 213 forks source link

Github code search doesnt work with folders called `build` #903

Open msaroufim opened 3 months ago

msaroufim commented 3 months ago

🐛 Describe the bug

I was trying to look for the model.py definition https://github.com/pytorch/torchchat/tree/main/build but it wasn't showing up

Screenshot 2024-07-15 at 6 54 39 PM

generate.py which is not in builder works fine

Screenshot 2024-07-15 at 6 54 54 PM

Can we rename the folder to anything else, build to me signifies either release infra scripts or artifacts that are created after installing a package not model building utilities

Versions

Nightlies

Jack-Khuu commented 3 months ago

I was able to repro the search results with the in repo search. Definitely a weird search interaction (the GH search from upper right does find it properly)

Regardless, build is an overloaded name and we'll look into renaming