pytorch / torcheval

A library that contains a rich collection of performant PyTorch model metrics, a simple interface to create new metrics, a toolkit to facilitate metric computation in distributed training and tools for PyTorch model evaluations.
https://pytorch.org/torcheval
Other
215 stars 47 forks source link

Fix error in BinaryPrecision computation #148

Closed bobakfb closed 1 year ago

bobakfb commented 1 year ago

Summary: Addressing gh issue https://github.com/pytorch/torcheval/issues/146

Binary Precision doesn't work when target is a float tensor.

Differential Revision: D45261417

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D45261417

bobakfb commented 1 year ago

Addressing #146

codecov[bot] commented 1 year ago

Codecov Report

Merging #148 (63aab81) into main (d53fa32) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files         170      170           
  Lines        9453     9453           
=======================================
  Hits         9042     9042           
  Misses        411      411           
Impacted Files Coverage Δ
...val/metrics/functional/classification/precision.py 98.46% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D45261417