search

pytorch / torcheval

A library that contains a rich collection of performant PyTorch model metrics, a simple interface to create new metrics, a toolkit to facilitate metric computation in distributed training and tools for PyTorch model evaluations.
https://pytorch.org/torcheval
Other
211 stars 46 forks source link

optimize repacking of metrics #163

Closed JKSenthil closed 1 year ago

JKSenthil commented 1 year ago

Summary: No longer deepcopies local rank metric and load state dict to create metric object for merging; instead the state_dicts are converted to objects directly and passed to the local rank metric merge_state

Differential Revision: D46737574

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46737574

codecov[bot] commented 1 year ago

Codecov Report

Merging #163 (0200d7e) into main (f6166a4) will decrease coverage by 0.27%. The diff coverage is 14.02%.

:exclamation: Current head 0200d7e differs from pull request most recent head fd89363. Consider uploading reports for the commit fd89363 to get more accurate results

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   24.45%   24.18%   -0.27%     
==========================================
  Files         176      178       +2     
  Lines       10349    10671     +322     
==========================================
+ Hits         2531     2581      +50     
- Misses       7818     8090     +272
Impacted Files Coverage Δ
tests/metrics/aggregation/test_cat.py 35.89% <ø> (ø)
tests/metrics/aggregation/test_throughput.py 33.33% <0.00%> (ø)
tests/metrics/test_metric.py 12.06% <ø> (+0.20%) :arrow_up:
tests/metrics/window/test_auroc.py 16.43% <ø> (ø)
tests/metrics/window/test_click_through_rate.py 20.68% <ø> (ø)
tests/metrics/window/test_mean_squared_error.py 11.57% <ø> (ø)
tests/metrics/window/test_weighted_calibration.py 21.42% <ø> (ø)
torcheval/metrics/aggregation/cat.py 50.00% <0.00%> (ø)
torcheval/metrics/window/auroc.py 15.85% <0.00%> (ø)
torcheval/metrics/window/click_through_rate.py 17.33% <0.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D46737574

facebook-github-bot commented 1 year ago

This pull request has been reverted by 4c0074368e6c418449209f4bca312531666d06c8.