Closed connernilsen closed 6 months ago
This pull request was exported from Phabricator. Differential Revision: D54436435
Seems like this was a mistake?
Hey @bobakfb, this wasn't a mistake. For updates coming to Pyre, we need to apply these comments in Python files that you want type checked.
It's not urgent that this is done, but starting in a few weeks, some functionality will stop working for type checking in the IDE. In around 6 months, type checking will stop working completely on these files. You can read more about this migration here.
If you don't want this migration to happen for torcheval, I can block the migration from going through for now. Just let me know here and I can make that change.
I'm going to retry again later -- would like to rerun on a fresher base revision.
Hey conner, I think it's fine to push this, but the linked diff on phabricator doesn't have the code linked in this PR. One thing to note is that we do ignore one particular warning at the top of all our class-based metrics, not sure if there is anything to consider there.
Summary: X-link: https://github.com/facebook/sapp/pull/108
X-link: https://github.com/pytorch/torchsnapshot/pull/168
X-link: https://github.com/pytorch/tnt/pull/717
X-link: https://github.com/facebook/pyre-check/pull/818
Reviewed By: connernilsen
Differential Revision: D54436435