q-shift / backstage-playground

2 stars 8 forks source link

Domain name ".qshift.snowdrop.dev" of the quarkus application URL is hard coded within the template #159

Open cmoulliard opened 5 months ago

cmoulliard commented 5 months ago

Issue

The domain name of the quarkus application URL is hard coded as we got this URL https://my-quarkus-app-1-dummy.apps.qshift.snowdrop.dev when a quarkus app has been deployed on the host : 10.0.77.131

See here => https://github.com/q-shift/backstage-playground/blob/main/locations/templates/quarkus-application/template.yaml#L296

Discussion between Ioannis and Charles

Ioannis: This should most probably be a parameter. If we could get this parameter to pickup a default value from the app-config.yaml that might be an acceptable solution

Charles: Yes but I don't know if we can populate a template parameter's list from a yaml list defined within the app-config.yaml except if we develop new code ....

Ioannis: From what I see we only use that to determine the component actual url. Maybe we need to ask the backstage folks if there is a better way to do that.

Charles: This is what I did !