search

qasim9872 / aws-transcribe

A client for Amazon Transcribe using the websockets API
https://www.npmjs.com/package/aws-transcribe
MIT License
10 stars 15 forks source link

Add types and change endpoint for medical transcription support #4

Closed jstockdale closed 4 years ago

jstockdale commented 4 years ago

Hi @qasim9872 –

Thanks for your awesome work on aws-transcribe.

I'm not sure if it's helpful, but I extended the library to support AWS Transcribe Medical. I wanted to contribute the changes back to your main repo if you find them useful.

I'm not 100% sure why some of the other files got changed when I built the packages and fixed a few dependencies that were out of date. If you want me to clean up this PR let me know. Otherwise feel free to just pull out the changes in AwsTranscribe.ts and types.ts and throw away the rest.

All my best, @jstockdale

jstockdale commented 4 years ago

I also went ahead and added support for custom vocabularies. It was super easy on top of the existing changes. Feel free to give feedback or let me know if you want this refactored. Cheers!

qasim9872 commented 4 years ago

Hey, thanks for extending the library. I was actually thinking of looking into custom vocabularies eventually so this saves me some time.

With this implementation, do you have to create a vocabulary set on amazon and then pass the name of that? What would be the approach if we wanted to set the vocabulary using the config at runtime?

The additional files which are in the dist folder are only required for this branch as this will be consumed directly and aren't required in master as the dist is provided by npm.