qbicsoftware / sample-notificator-cli

A command line tool to handle sample status change notifications
MIT License
0 stars 0 forks source link

Introduce logging of sendmail process output and failure email sending to admin #28

Closed Steffengreiner closed 3 years ago

Steffengreiner commented 3 years ago

Description of Changes 1.) Introduces a failure email template, which will be send to the responsible party/sysadmin if the sendmail process of the notification-cli fails. 2.) Also pipes the terminal output of the sendmail process into a dedicated logging file 3.) Also pipes the output of the use cases to the same logging file via failNotification.

Technical information Sendmail sends details about its output into /var/log/maillog file. This PR also introduces a dedicated log file notification-cli.log which will contain the piped terminal output of the sendmail process and if the use case fails the use case output. logging is now done via the log4j class in which the settings are specified in the log4j.xml file

Is this required? Technical Improvements in general 1.) Have the logging in the custom file be done in a seperate class 2.) The path to the logging file could be set to a seperate config file. 3.) Improve the log output from the use cases (Log4j?)
4.) Improve the dummy mail to the Sysadmin