search

qiuxiafei / zk-web

A web UI for zookeeper
500 stars 153 forks source link

Doesn't support Environment Variable PORT #13

Closed drusellers closed 9 years ago

drusellers commented 9 years ago

Trying to use zk-web with foreman but doesn't support changing the port number based on environment variable.

qiuxiafei commented 9 years ago

why not edit the config file?

drusellers commented 9 years ago

Short Answer: http://12factor.net/ :)

Also, foreman will pass a PORT environment variable to be used and it would be nice to be able to use foreman. Foreman, will also spit out upstart files, systemd files which makes running my tools much easier. I'm happy to contribute a change that will allow both the config file and the env var.

qiuxiafei commented 9 years ago

it would be nice if u can contribute.

drusellers commented 9 years ago

Ok, cool beans. Are you ok if I pull in the environ package? https://github.com/weavejester/environ

qiuxiafei commented 9 years ago

If it can be achieved by simply wrap System.getEnv(), don't introduce unnecessary external library.^_^