qmarcou / IGoR

IGoR is a C++ software designed to infer V(D)J recombination related processes from sequencing data. Find full documentation at:
https://qmarcou.github.io/IGoR/
GNU General Public License v3.0
47 stars 25 forks source link

Pip locally installable pygor module. #17

Closed penuts7644 closed 6 years ago

penuts7644 commented 6 years ago

Three changes were made:

I haven't made changes to the code itself. Also good to know that I used your (@qmarcou) contact information in the setup.py file.

qmarcou commented 6 years ago

Thank you so much for your help @penuts7644 ! I've been through your changes everything seems to work like a charm except for one change in your last commit about the 'Mismatch' vs 'Error' column in the bestscenarios module. See my comment inplace. If you don't mind, I think it would be simpler and more transparent that you edit your PR rather than me accepting it and making the change again on top of it. My apologies for the delay in my response and proper check, again many thanks!

qmarcou commented 6 years ago

Thanks for the swift change! I'll close and merge this PR now, thanks a lot for your help!